Skip to content

Make ReadOnly TypedDict items covariant#17904

Merged
JukkaL merged 1 commit into
masterfrom
readonly-covariant
Oct 9, 2024
Merged

Make ReadOnly TypedDict items covariant#17904
JukkaL merged 1 commit into
masterfrom
readonly-covariant

Conversation

@JukkaL

@JukkaL JukkaL commented Oct 9, 2024

Copy link
Copy Markdown
Collaborator

Fixes #17901.

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@github-actions

github-actions Bot commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@JukkaL JukkaL merged commit e126ba0 into master Oct 9, 2024
@JukkaL JukkaL deleted the readonly-covariant branch October 9, 2024 13:48
JukkaL added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReadOnly TypedDict items should be treated as covariant

3 participants